Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command JSON.MGET #495

Closed
arpitbbhayani opened this issue Sep 8, 2024 · 3 comments
Closed

Add support for command JSON.MGET #495

arpitbbhayani opened this issue Sep 8, 2024 · 3 comments
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

arpitbbhayani commented Sep 8, 2024

Add support for the JSON.MGET command in DiceDB similar to the JSON.MGET command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@raghavbabbar
Copy link
Contributor

raghavbabbar commented Sep 8, 2024

could you please assign this to me @arpitbbhayani

@arpitbbhayani
Copy link
Contributor Author

arpitbbhayani commented Sep 8, 2024

@raghavbabbar assigned. Thanks for picking this up.

lucifercr07 pushed a commit that referenced this issue Sep 12, 2024
* Added the command JSON.FORGET implementation
raghavbabbar added a commit to raghavbabbar/dice that referenced this issue Sep 15, 2024
@raghavbabbar
Copy link
Contributor

#589

JyotinderSingh added a commit that referenced this issue Sep 16, 2024
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants