Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Table print fix for single threading num shards #1221

Merged
merged 25 commits into from
Oct 30, 2024

Conversation

AshwinKul28
Copy link
Contributor

Followup of #1217

@AshwinKul28
Copy link
Contributor Author

Screenshot 2024-10-30 at 7 36 56 PM

All options are working perfectly fine.

@AshwinKul28
Copy link
Contributor Author

Screenshot 2024-10-30 at 7 37 47 PM

Single-threaded mode is showing up correctly.

@AshwinKul28 AshwinKul28 merged commit e6f2c43 into DiceDB:master Oct 30, 2024
2 checks passed
@AshwinKul28 AshwinKul28 deleted the splash branch October 30, 2024 14:08
rushabhk04 pushed a commit to rushabhk04/dice that referenced this pull request Nov 1, 2024
* removed unwanted goroutine

* made errors lowercase to match with the existing scenario of redis

* added startup splash and info table

* Update main.go

* more refactoring

* fixed printing of num shards in case of single threading

---------

Co-authored-by: Ashwin Arvind Kulkarni <Ashwin.Arvind.kulkarni@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant