-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1260: Runs CI only when source code has changes. #1265
Conversation
…there is no changes in .go files
24b195f
to
fcfa7c6
Compare
Thanks for this change @bhima2001! Would it be possible for you to run the CI with these changes on your fork? You can then attach the logs here. This will help us verify that this change is doing what its supposed to. |
https://github.com/bhima2001/dice/actions/runs/11812884490/job/32909079862 --> These are the logs when a .go file has some changes |
@JyotinderSingh If there are changes in any other file types other that .go then the test_suite job is not getting executed (expected). Please checkout the previous commits made in this branch, I have tested it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement @bhima2001! LGTM.
Added a condition to execute the test suite only incase there is any changes in .go files and also added a cache in linter to store the go setup. This pr closes #1260 .