Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor makefile #1288

Merged
merged 2 commits into from
Nov 20, 2024
Merged

refactor makefile #1288

merged 2 commits into from
Nov 20, 2024

Conversation

vinitparekh17
Copy link
Contributor

@vinitparekh17 vinitparekh17 commented Nov 16, 2024

This pull request includes significant changes to the Makefile to improve the organization and clarity of the available commands. The changes primarily focus on restructuring the help commands and adding descriptions for each make target.

Improvements to Makefile organization and clarity:

  • Changed the default goal to help and added a formatted help command to display available targets and their descriptions.
  • Grouped targets into categories (Helpers, Building, Testing, Benchmarking, Development) and added descriptions for each target. [1] [2]
  • Added new targets for running the project (run, run-docker)

before

before make

after

make

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look crazy great. Amazing work!

@JyotinderSingh JyotinderSingh merged commit 3b2d99a into DiceDB:master Nov 20, 2024
1 check passed
@vinitparekh17 vinitparekh17 deleted the makefile branch November 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants