Refactor configuration management to use a .conf file #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitparekh17
force-pushed
the
config-refactor
branch
from
f1ede1c
to
0aef75b
Compare
|
Do flags take precedence over the config? (They should) |
vinitparekh17
force-pushed
the
config-refactor
branch
from
0aef75b
to
339feb1
Compare
They should and They will, thanks for noticing |
vinitparekh17
force-pushed
the
config-refactor
branch
from
3af4c6c
to
a9b8879
Compare
JyotinderSingh
changed the title
|
Awesome, thanks for these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brought back all flags, as we discussed @JyotinderSingh