-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for COMMAND command #458
Added support for COMMAND command #458
Conversation
Please rebase the PR, we just had a large change go in which might've introduced conflicts. |
1bc404d
to
48774fd
Compare
@JyotinderSingh due to this refatcoring, some changes of mine are breaking. The struct DiceCmdMeta is now not exposed to the package clientio which is needed to appropriately format the output for the COMMAND command. What should be the course of action? Will it be acceptable to move this struct to a new package called Models so that the cyclic dependency chain breaks? |
@aashraybhandar1 There are some test failures. Please fix the test failures and we will give it a final skim post that. thanks for the patch. |
@lucifercr07 thanks for the suggestion. I have tried implementing it with this new commit. Would appreciate your feedback on the same. Thank You! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aashraybhandar1 for PR, please check the review comment once.
@aashraybhandar1 changes LGTM, will contain an issue to maintain the format parity with Redis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Approved. Thanks @aashraybhandar1 for working on this.
* Added support for COMMAND command --------- Co-authored-by: Aashray Bhandari <aashraybhandari@Aashrays-MacBook-Air.local>
Summary
Added support for COMMAND command. Please review.
COMMAND is used to return an array with details about every DiceDB command.
redis documentation : https://redis.io/docs/latest/commands/command/
Changes
Benchmark results

Issue: #144