Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep package-lock.json for reproducibility #874

Closed
TomaSajt opened this issue Oct 23, 2023 · 1 comment
Closed

Keep package-lock.json for reproducibility #874

TomaSajt opened this issue Oct 23, 2023 · 1 comment

Comments

@TomaSajt
Copy link
Contributor

I am currently trying to package this app for Nixpkgs (NixOS/nixpkgs#255715, still WIP), and it requires me to have a package-lock.json to have reproducible builds. Currently, I am just generating the lockfile and committing it to the Nixpkgs repo, but it would be helpful if that was handled here, on the upstream.
@Difegue
Copy link
Owner

Difegue commented Oct 23, 2023

I currently just gitignore the package-lock file as I thought it was unnecessary - don't mind changing that if it can help. ✌️

Difegue added a commit that referenced this issue Oct 24, 2023
@Difegue
(#874) Add missing package-lock.json file
c5cd864
@Difegue Difegue closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Difegue @TomaSajt