-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EHPlugin update for the new search system #707
Conversation
updated text search for the new search system (mostly just removing now deprecated flags) image search no longer supports searching tags
"- Selecting "Search Expunged Galleries" will now only search expunged galleries in normal searches. (File searches, GID searches and favorite searches will always display both normal and expunged galleries.)"
searching by gID extracted from the title name (when for example downloaded from H@H), will fallback to title name if no gID is found or the search fails due to a false match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, I wasn't aware of that search change before seeing that PR!
Could you look into making sure the basic search test doesn't fail? (You can see the test run here)
Looks like it's now returning https://exhentai.org/g/2366539/83aa0d7d05 instead of https://exhentai.org/g/618395/0439fa3666/ , which seems a bit wrong.
It fails because e-hentai doesn't have the new search system yet, need to use ex right now. (Im assuming it doesn't use ex for the tests?) Well after a bit of testing i can conclude that the new search just sucks. (but not related to the test failing, that's just because EH is still on the old system) The GID search at least works nicely when its included in the title. |
After a few updates it looks like its working as expected or even better again. Still waiting for EH to use the new system now. |
Alright, that looks fine -- I guess we can merge this for now, so that people who use ex can move to nightly builds if they want. Hopefully the change moves to EH as well before I get to make a release 🙏 Thanks again! |
So while i believe the text search should still work fine i went ahead and updated it anyway.
Additionally from what i understand the image search works best (only works?) when using the full image hash not the thumbnail hash.
Also we can now search by gID which can be added as an option later.Added an option for this, worked nicely and will fall back to title name if no gId found or search failed.
[2022-11-02 19:11:23] [E-Hentai] [debug] Found gID: 2365440, Using URL https://exhentai.org?f_search=gid%3A2365440 (gID from archive title) [2022-11-02 19:11:23] [E-Hentai] [debug] EH API Tokens are 2365440 / 9ff65b23c7
read more here: https://forums.e-hentai.org/index.php?showtopic=261743&pid=6201235