Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use File::Temp rather than homebrew stuff #807

Merged
merged 1 commit into from
May 17, 2023

Conversation

siliconfeces
Copy link
Contributor

Creating unique temporary files that isn't vulnerable to race conditions is tricky. Delegate that complexity to Somebody Else™

@Difegue Difegue merged commit 1fcc663 into Difegue:dev May 17, 2023
@holopin-bot
Copy link

holopin-bot bot commented May 17, 2023

Congratulations @siliconfeces, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clhrxoay4399290fmnlpphy36i

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@Difegue
Copy link
Owner

Difegue commented May 17, 2023

Works for me, it makes for less code as well and File::Temp is already included. Thanks!

@siliconfeces siliconfeces deleted the safe_tmpfile branch June 10, 2023 21:40
@polak14
Copy link
Contributor

polak14 commented Jul 5, 2023

Importing tags from eze or koromo errors for me with this PR

Error while fetching tags :
Error: mkdir /usr/lib/lanraragi/public/temp/plugin/AIrR2CZ_1q: File exists at /usr/lib/lanraragi/script/../lib/LANraragi/Utils/Archive.pm line 303.

@siliconfeces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants