Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Get Student ID" or "StudentId" headers to something else.. #145

Closed
Brend-Smits opened this issue May 25, 2020 · 0 comments · Fixed by #152
Closed

Rename "Get Student ID" or "StudentId" headers to something else.. #145

Brend-Smits opened this issue May 25, 2020 · 0 comments · Fixed by #152
Assignees
@wotwot563
Labels
requires development

Comments

@Brend-Smits
Copy link
Member

In the backend and Identity server we're often referring to the 'student id", this is incorrect as not only students use the platform.
We should change it and the corresponding methods to something more descriptive, perhaps RegisteredUserId or UserId?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wotwot563 wotwot563

Labels
requires development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed all references to the student DigitalExcellence/dex-backend
2 participants
@Brend-Smits @wotwot563