Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all references to the student #152

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

wotwot563
Copy link

@wotwot563 wotwot563 commented May 27, 2020

Description

The project referenced the id from the identity server as the student id, this was wrong and is now replaced by identityid.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Search for student in the project.

Link to issue

Closes: #145

@wotwot563 wotwot563 self-assigned this May 27, 2020
@Brend-Smits
Copy link
Member

Description
A few sentences describing the overall goals of the pull request's commits.

@Brend-Smits
Copy link
Member

Thanks!

@wotwot563 wotwot563 merged commit afcf809 into develop Jun 2, 2020
@wotwot563 wotwot563 deleted the feature/145_rename_student_id branch June 2, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Get Student ID" or "StudentId" headers to something else..
3 participants