-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/problemdetails #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are postman tests in this branch as well?
Next time please keep the checklist in the pull request in the description, just check what you have done :) |
4e28176
to
32b12a9
Compare
32b12a9
to
f0ec106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you added an explanation or guide to the wiki so developers know how they must write error responses? If not, please add it.
Description
This issue makes our errors conform RFC 7807, with added GUIDS for easy error traceback.
Type of change
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
example: do a get request to /api/Project/-1
header:
Content-type: application/problem+json
body:
{
"title": "Failed getting project.",
"status": 400,
"detail": "The Id is smaller then 0 and therefore it could never be a valid project id.",
"instance": "D590A4FE-FDBA-4AE5-B184-BC7395C45D4E"
}
Link to issue
Closes: #80