Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/problemdetails #106

Merged
merged 5 commits into from
May 5, 2020
Merged

Feature/problemdetails #106

merged 5 commits into from
May 5, 2020

Conversation

wotwot563
Copy link

@wotwot563 wotwot563 commented Apr 23, 2020

Description

This issue makes our errors conform RFC 7807, with added GUIDS for easy error traceback.

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. make a request that is not valid:
    example: do a get request to /api/Project/-1
  2. the result should be:
    header:
    Content-type: application/problem+json
    body:
    {
    "title": "Failed getting project.",
    "status": 400,
    "detail": "The Id is smaller then 0 and therefore it could never be a valid project id.",
    "instance": "D590A4FE-FDBA-4AE5-B184-BC7395C45D4E"
    }

Link to issue

Closes: #80

Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are postman tests in this branch as well?

@Brend-Smits
Copy link
Member

Next time please keep the checklist in the pull request in the description, just check what you have done :)
Can you assign it to the correct project board?

@Brend-Smits Brend-Smits self-assigned this May 4, 2020
Copy link
Member

@StijnGroenen StijnGroenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added an explanation or guide to the wiki so developers know how they must write error responses? If not, please add it.

@StijnGroenen StijnGroenen merged commit 4e44e9e into develop May 5, 2020
@StijnGroenen StijnGroenen deleted the feature/problemdetails branch May 5, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling API, should we use headers to let the Frontend know?
3 participants