Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/139 get user from httpcontext #144

Merged
merged 5 commits into from
May 26, 2020

Conversation

wotwot563
Copy link

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. log in to the identity server
  2. create a project
  3. check if the project user is the current user

Link to issue

Closes: #139

@wotwot563 wotwot563 self-assigned this May 21, 2020
Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I will run some quick tests soon and check out other controllers to make sure we did not miss one.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Brend Smits <brend_smits@hotmail.com>
@Brend-Smits Brend-Smits self-requested a review May 25, 2020 08:49
Brend-Smits
Brend-Smits previously approved these changes May 25, 2020
@Brend-Smits Brend-Smits self-requested a review May 26, 2020 14:10
Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@wotwot563 wotwot563 merged commit 09d9fc7 into develop May 26, 2020
@wotwot563 wotwot563 deleted the feature/139-get-user-from-httpcontext branch May 26, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project-Create - Get user from httpcontext
3 participants