Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed projects filter bug #199

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

StijnGroenen
Copy link
Member

Description

This PR fixes the bug that resulted in unexpected results on the projects endpoint.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Steps to reproduce the behaviour:

  • Go to project overview
  • Select only non-highlighted
  • Set sorting to name
  • Change sorting from asc to desc
  • The results are as expected

Link to issue

Closes: #185

CHANGELOG.md Outdated Show resolved Hide resolved
rubenb994
rubenb994 previously approved these changes Jun 17, 2020
Co-authored-by: RensvdLinden <46752038+RensvdLinden@users.noreply.github.com>
@StijnGroenen StijnGroenen merged commit d025523 into develop Jun 17, 2020
@StijnGroenen StijnGroenen deleted the feature/fixed-projects-endpoint-bug-185 branch June 17, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Endpoints returns unexpected results
3 participants