Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose for Development #235

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Conversation

Brend-Smits
Copy link
Member

Description

Docker-compose was broken due to the addition of persistence storage #159 in the Identity Server. I fixed it by adding a connection string to the IDS.
Tested this with @juliaslaats and @liekevdvoort and it now works for them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Follow getting-started docker guide

Link to issue

Closes: #234

docker-compose.yml Outdated Show resolved Hide resolved
wotwot563
wotwot563 previously approved these changes Sep 17, 2020
@wotwot563
Copy link

Also maybe an improvement, we could use the container names instead of the ip addresses. this could enhance the readability of the docker compose file and remove possible ip conflicts etc.

…er to the image. This is what caused the issue where the frontend of the identity server was stripped of CSS/Icons
@Brend-Smits Brend-Smits merged commit 351f759 into develop Sep 23, 2020
@Brend-Smits Brend-Smits deleted the bugfix/234-fix-docker-dev branch September 23, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker not working in dev environments
3 participants