Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/317 include collaborators project overview #318

Merged

Conversation

waltersajtos
Copy link
Member

@waltersajtos waltersajtos commented Nov 29, 2020

Description

Because of the redesign of the project overview page, we need the collaborators for every project.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Make a GET request to /api/project
  2. The response should include the collaborators

Link to issue

#317

Closes: #317

@waltersajtos waltersajtos self-assigned this Nov 29, 2020
@waltersajtos waltersajtos added the priority Only assign this label if it's asked to assign this label label Nov 29, 2020
Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you didn't add a description for this pull request. I understand it's a lot of work to add a description for a small issue like this. However, I don't think we need to skip them, I think it's important to create a description for small issues as well 😄 .

And another small thing: do you think this is a New feature? Don't you think it's rather a bugfix (which fixes in issue for the frontend?).

Overall the code looks good and works like a charm

API/Resources/ProjectResultResource.cs Outdated Show resolved Hide resolved
@waltersajtos
Copy link
Member Author

I noticed you didn't add a description for this pull request. I understand it's a lot of work to add a description for a small issue like this. However, I don't think we need to skip them, I think it's important to create a description for small issues as well 😄 .

And another small thing: do you think this is a New feature? Don't you think it's rather a bugfix (which fixes in issue for the frontend?).

Overall the good looks good and works like a charm

You are right, I edited the description but forgot to save it :)
I wasn't sure what to call it, since it isn't really a bug because the behavior was expected.

@waltersajtos waltersajtos merged commit 2e201a2 into develop Nov 30, 2020
@waltersajtos waltersajtos deleted the feature/317-include-collaborators-project-overview branch November 30, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Only assign this label if it's asked to assign this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include collaborators on project overview
3 participants