Project Retrieval endpoints return Likes #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joining the tables by using Include() caused the query to take sometimes up to 10 times as long. This was an issue as it caused drastic slow down when retrieving all projects, retrieving project detail or when searching for projects.
Likes were not being returned when retrieving projects. Due to performance reasons, we are just returning an array for now with user id + date instead of Like Count and boolean to check if currently logged in user has liked that specific project. In the future we should probably move the like and follow things into their own controller with respective services. The frontend can then make a call to retrieve project meta data, which can take a little longer and should be non-blocking for the frontend. For now, the frontend can count the objects in the likes array and check if a user id is equal to the one that is logged in. Fixes #329.
… feature/329-improved-project-likes
Brend-Smits
changed the title
…es' into feature/329-improved-project-likes
|
Integration check is failing based on performance external wizard call, just FYI |
waltersajtos
previously approved these changes
Dec 7, 2020
RubenFricke
requested changes
Dec 7, 2020
There was a problem hiding this comment.
The code looks really clean. I'm sorry to nitpick, but in your documentation, you sometimes end the sentence with a dot, and sometimes you don't do this. According to the code guidelines
End comment text with a period. I suggest do end it with a dot all the time (if it's a correct sentence. On my first PR I got some great discussion about this, and we decided to only end the sentence with a dot whenever it's a correct sentence.)
RubenFricke
approved these changes
Dec 7, 2020
waltersajtos
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Likes were not being returned when retrieving projects. Due to performance reasons, we are just returning an array for now with user id + date instead of Like Count and boolean to check if the currently logged-in user has liked that specific project.
In the future, we should probably move the like and follow things into their own controller with respective services. The frontend can then make a call to retrieve project metadata, which can take a little longer and should be non-blocking for the frontend.
For now, the frontend can count the objects in the likes array and check if a user-id is equal to the one that is logged in.
Fixes #329.
#335 should be merged before this as I merged that branch in this one to investigate performance while retrieving likes.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
Link to issue
Closes: #329