Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/352 dataofficer institution update #354

Merged
merged 8 commits into from
Jan 18, 2021

Conversation

RubenFricke
Copy link
Member

Description

People can't add themselves to an institution. This was possible and data officers were able to switch institutions and retrieve access to institutions they should not have access to.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Validate you can update your own account, except updating your institution id.
  2. Validate a data officer can update the data from users from their institution, except updating the institution id. They should be able to delete users from their institution.

Link to issue

Closes: #352

@waltersajtos waltersajtos mentioned this pull request Jan 18, 2021
13 tasks
@RubenFricke RubenFricke merged commit a534f58 into develop Jan 18, 2021
@RubenFricke RubenFricke deleted the bugfix/352-dataofficer-institution-update branch January 18, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data officer can change institution in unwanted moments
3 participants