Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/430 add images to project #445

Merged
merged 13 commits into from
Jun 2, 2021

Conversation

macfleury-2000
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Add a file (image)
  2. Add a project with multiple files
  3. Open project and note that the right files are added

Link to issue

Closes: #430

Copy link
Member

@JVerbruggen JVerbruggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please look at the requested changes. Nice GitHub name btw xdd

API/Controllers/ProjectController.cs Outdated Show resolved Hide resolved
API/Controllers/ProjectController.cs Outdated Show resolved Hide resolved
API/Controllers/ProjectController.cs Show resolved Hide resolved
@JVerbruggen
Copy link
Member

Also take a look at why the unit & integration tests fail

waltersajtos
waltersajtos previously approved these changes Jun 1, 2021
Copy link
Member

@waltersajtos waltersajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was something weird going on with the File class types. All other changes look good, good work!

TimSnoek123
TimSnoek123 previously approved these changes Jun 1, 2021
Copy link
Contributor

@TimSnoek123 TimSnoek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prima.

JVerbruggen
JVerbruggen previously approved these changes Jun 2, 2021
Copy link
Member

@JVerbruggen JVerbruggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macfleury-2000 macfleury-2000 merged commit 6814f6a into develop Jun 2, 2021
@macfleury-2000 macfleury-2000 deleted the feature/430-add-images-to-project branch June 2, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add images to projects
5 participants