Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited amount of images per project to 10 #476

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

niraymak
Copy link
Member

@niraymak niraymak commented Jun 25, 2021

Description

Limited amount of images per project to 10

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Link more than 10 images to a project. (Both POST / PUT requests)
Check if the API returns bad request.

Link to issue

Closes: #475

@niraymak niraymak requested a review from Arilith June 28, 2021 12:07
Copy link
Member

@JVerbruggen JVerbruggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@RubenFricke RubenFricke merged commit 0b99e31 into develop Jun 29, 2021
@RubenFricke RubenFricke deleted the bugfix/475-project-images-limit branch June 29, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a maximum amount of images that can be uploaded to a project
3 participants