Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/505 add my projects page #534

Merged
merged 38 commits into from
Jun 29, 2021

Conversation

macfleury-2000
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Login with identity server or FHICT account
  2. If the logged in user hasn't uploaded any projects, upload a project
  3. Hover over your profile picture (top right corner)
  4. Click on my projects
  5. See (all) your project(s) appear here

#505

Closes: #505

Copy link
Member

@niraymak niraymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort! :) I had a few remarks, can you please check them out?

When I loaded the "my projects" (logged in as a user with no uploaded projects) a infinite loading icon showed up.

Something seems to go wrong in mobile view, I guess because of the userinfo :
image

Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Fleur! Looks really good and I think this will be a great feature to have! I have 2 small remarks.

In my opinion, it's not expected that the 'my projects'-option is automatically selected.
image

I also noticed that when I opened a modal and hit the browser's back button, I was sent back a page instead of just closing the modal just like the project overview page.

Overall it looked really good, thanks for your contribution.

@niraymak
Copy link
Member

niraymak commented Jun 28, 2021

Good job Fleur! Looks really good and I think this will be a great feature to have! I have 2 small remarks.

In my opinion, it's not expected that the 'my projects'-option is automatically selected.
image

I also noticed that when I opened a modal and hit the browser's back button, I was sent back a page instead of just closing the modal just like the project overview page.

Overall it looked really good, thanks for your contribution.

Good job Fleur! Looks really good and I think this will be a great feature to have! I have 2 small remarks.

In my opinion, it's not expected that the 'my projects'-option is automatically selected.
image

I also noticed that when I opened a modal and hit the browser's back button, I was sent back a page instead of just closing the modal just like the project overview page.

Overall it looked really good, thanks for your contribution.

The my projects option is only selected if you are on the page for me. Edit: I agree that the styling doesn't look so great.
Tried to refactor the behaviour when pressing "back". Didn't get it working unfortunately. On the home page the modals have the same behaviour.

@macfleury-2000 macfleury-2000 merged commit 8aab07e into develop Jun 29, 2021
@macfleury-2000 macfleury-2000 deleted the feature/505-add-my-projects-page branch June 29, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add my projects page
4 participants