-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/505 add my projects page #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/app/components/auth-callback/auth-callback.component.css.map
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Fleur! Looks really good and I think this will be a great feature to have! I have 2 small remarks.
In my opinion, it's not expected that the 'my projects'-option is automatically selected.
I also noticed that when I opened a modal and hit the browser's back button, I was sent back a page instead of just closing the modal just like the project overview page.
Overall it looked really good, thanks for your contribution.
Description
A few sentences describing the overall goals of the pull request's commits.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
#505
Closes: #505