Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/499 sort projects on likes #542

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

RubenFricke
Copy link
Member

Description

Added search functionality based on the number of likes in the project overview page.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Navigate to the project overview page
  2. Like some projects
  3. Select in the filter menu 'Likes (high-low)
  4. Validate that the projects get sorted on the number of likes in desc order
  5. Select in the filter menu 'LIkes (low-high)
  6. Validate that the projects get sorted on the number of likes in asc order

Link to issue

Closes: #499

@RubenFricke RubenFricke added requires review Good first issue Good first issue to get to know the project internally. labels Jun 28, 2021
@RubenFricke RubenFricke self-assigned this Jun 28, 2021
Copy link
Member

@waltersajtos waltersajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the impressive implementation 😝 Looks good to me! :D

@RubenFricke RubenFricke merged commit 2e172bc into develop Jun 28, 2021
@RubenFricke RubenFricke deleted the feature/499-sort-projects-on-likes branch June 28, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good first issue to get to know the project internally. requires review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Projects based on likes
3 participants