CREATE TRANSFORMATION : As an Open Source User, I want to be able to set up a new transformation using my extracted data, so that I can make use of it in the way I need. #4
Conversation
Create an extraction See an Extraction See a preview record for the extracted data
Add the ability to edit a transformation
Added the abiltiy to delete a transformation
Added the ability to be able to test a transformations record selector
Improve Job selection box so that they are grouped by their respective extraction definition.
There was a problem hiding this comment.
Would it be good to install codeclimate_diff so that it can be run? I was curious if there were any regressions.
I ran the audit on it, and it returned:
| NAME | ORGANISATION | REPO_HOST | RELATIVE_PATH | FOLDER | MAIN_BRANCH | SIMILARITY_SCORE_PER_FILE | ABC_METHOD_AVERAGE | CODE_SMELLS_PER_FILE | TOTAL_SCORE |
|---|---|---|---|---|---|---|---|---|---|
| supplejack_harvester | DigitalNZ | github.com | ../ | app | create-transformation | 2.74 | 6.1 | 0.41 | 9.25 |
main currently looks like this:
| NAME | ORGANISATION | REPO_HOST | RELATIVE_PATH | FOLDER | SIMILARITY_SCORE_PER_FILE | ABC_METHOD_AVERAGE | CODE_SMELLS_PER_FILE | TOTAL_SCORE |
|---|---|---|---|---|---|---|---|---|
| supplejack_harvester | DigitalNZ | github.com | ../ | app | 1.14 | 6.1 | 0.35 | 7.59 |
Yeah that's a good idea @isabel-anastasiadis-boost! I'll add it |
| document.addEventListener('DOMContentLoaded', function () { | ||
|
|
||
|
|
||
| function sendData(form) { |
There was a problem hiding this comment.
This is quite a big function, would it be easier to read if it was split up a bit? It seems to do more than just send data
There was a problem hiding this comment.
Yeah this is a copy of another test feature that we have. I think we will revisit these when we have a javascript framework in the mix.
There was a problem hiding this comment.
Ahh, it could be that this is one of the code duplication things that was identified too then.
There was a problem hiding this comment.
Could be good to at least not have the duplication if it is mostly a copy paste. Then it is easier to keep improving later
|
|
||
| // Transformation Raw Data Record Viewer | ||
|
|
||
| const raw_data_record_viewer = document.querySelector("#raw-data-record-viewer"); |
There was a problem hiding this comment.
This code looks a bit repeated - could it be extracted to a shared function somehow?
| @@ -67,4 +67,8 @@ def duration_seconds | |||
| def extraction_folder_size_in_bytes | |||
| `du #{extraction_folder} | cut -f1`.to_i | |||
| end | |||
|
|
|||
| def name | |||
There was a problem hiding this comment.
Why is the job name a date? Do you want doc comments like the other methods?
There was a problem hiding this comment.
The date is the only identifying information we have at the moment about the job and we show the date it was run on the front end :)
There was a problem hiding this comment.
Is 'name' a misnomer though? Just wondering if it is actually a name or not. And if it is a formatted date, is that view logic, or model logic? Up to you, it just seemed a bit odd to me :)
There was a problem hiding this comment.
That's fair :). I actually made this method so that I could get the name for the job in a rails form helper but I am not using that anymore so I will get rid of this method
Acceptance Criteria