Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HARVESTER OPEN SOURCE ISSUES: As Richard, I want to be able to contribute to open source SJ, so that versions don't drift apart and cause problems later #65

Merged
merged 8 commits into from
May 5, 2024
Merged

HARVESTER OPEN SOURCE ISSUES: As Richard, I want to be able to contribute to open source SJ, so that versions don't drift apart and cause problems later #65

merged 8 commits into from
May 5, 2024

Conversation

danielaboost
Copy link
Contributor

@danielaboost danielaboost commented May 2, 2024 •
edited
Loading

  • Moving the harvester credentials to kubernetes so external parties can merge changes in
  • Removed webdrivers and replaced with selenium-webdrivers to fix testing pipeline

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Code quality score

Lovely, the code quality is unchanged for this PR 😊

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 86 6.5 5.36 16.8 28.66
this branch 86 6.5 5.36 16.8 28.66
difference 0 0.0 0.0 0.0 0.0

tom-mcculloch
tom-mcculloch approved these changes May 5, 2024
View reviewed changes
Copy link

@tom-mcculloch tom-mcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luv ur wurk

@danielaboost danielaboost merged commit f5d19a5 into main May 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-mcculloch tom-mcculloch tom-mcculloch approved these changes

@richardmatthewsdev richardmatthewsdev richardmatthewsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielaboost @richardmatthewsdev @tom-mcculloch