Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specify-enrichment-fields): Allow specifying particular fields from the Enrichment to prevent returning unnecessary fields #90

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

richardmatthewsdev
Copy link
Contributor

A good example is if you have a fulltext field that you do not need for the enrichment, it gets returned anyway and takes up space in the filesystem and slows down the response. Especially if it is in the merged fragment as well as an embedded fragment.

Copy link

Code quality score

Uh oh! The code quality got worse for this PR! Better take a look!! 🚨

Ruby file count Similarity score (flay) ABC complexity (flog) Code smells (reek) TOTALS
base 109 7.67 5.2 17.1 29.97
this branch 109 7.73 5.2 17.15 30.08
difference 0 ⚠️ 0.06 0.0 ⚠️ 0.05 0.11

Copy link
Contributor

@motizuki motizuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@richardmatthewsdev richardmatthewsdev merged commit 0fe22a0 into main Sep 12, 2024
7 of 8 checks passed
@richardmatthewsdev richardmatthewsdev deleted the rm/specify-enrichment-fields branch September 12, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants