style: codeclimate fixes

app/helpers/parsers_helper.rb

@@ -44,7 +44,7 @@ def link_to_next(parser_id, index, environment, review, html_options = {})
   def link_to_previous(parser_id, index, environment, review, html_options = {})
     index = index.to_i - 1
     path = previews_path(
-      parser_id: :parser_id,
+      parser_id: parser_id,
       index: index,
       environment: environment,
       review: review
@@ -62,8 +62,7 @@ def link_to_previous(parser_id, index, environment, review, html_options = {})
   def environment_tags(version, parser)
     content_tag(:div, class: 'version-tag-container') do
       bubbles = []
-      version.tags ||= []
-      version.tags.each do |environment|
+      (version.tags ||= []).each do |environment|
         label = environment.capitalize.first
         arrow = nil
         classes = ['version-tag', environment]

app/models/concerns/versioned.rb

@@ -21,7 +21,7 @@ def last_edited_by
   end
 
   def current_version(environment)
-    return versions.last if environment.to_sym == :test || environment.to_sym == :preview
+    return versions.last if environment.to_sym.in? [:test, :preview]
     versions.where(tags: environment.to_s).desc(:created_at).first
   end
 

app/models/harvest_schedule.rb

@@ -36,7 +36,8 @@ def find_from_environment(params, env)
 
     def destroy_all_for_parser(parser_id)
       environments = APPLICATION_ENVS
-      environments = [Rails.env] if ['development', 'test'].include? Rails.env
+      rails_env = Rails.env
+      environments = [rails_env] if ['development', 'test'].include? rails_env
 
       environments.each do |env|
         HarvestSchedule.find_from_environment({ parser_id: parser_id }, env).each do |hs|