Skip to content

Commit

Permalink
check for order cancellation failure (#855)
Browse files Browse the repository at this point in the history
  • Loading branch information
vslee authored Nov 22, 2024
1 parent 67c7301 commit b595119
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
}
catch (Exception ex) // All fails come back with an exception.
{
Logger.Error(ex, "Failed to place coinbase error");
Logger.Error(ex, "Failed to place coinbase order");
var token = JToken.Parse(ex.Message);
return new ExchangeOrderResult(){
Result = ExchangeAPIOrderResult.Rejected,
Expand All @@ -479,9 +479,14 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd

protected override async Task OnCancelOrderAsync(string orderId, string marketSymbol = null, bool isClientOrderId = false)
{
Dictionary<string, object> payload = new Dictionary<string, object>() {{ "order_ids", new [] { orderId } } };
await MakeJsonRequestAsync<JArray>("/orders/batch_cancel", payload: payload, requestMethod: "POST");
}
Dictionary<string, object> payload = new Dictionary<string, object>() {{ "order_ids", new [] { orderId } } };
var responseJObj = await MakeJsonRequestAsync<JObject>("/orders/batch_cancel", payload: payload, requestMethod: "POST");
if (responseJObj["results"][0].Value<bool>("success") != true)
{
Logger.Error("Failed to cancel coinbase order. {0}", responseJObj["results"][0].Value<string>("failure_reason"));
throw new APIException("Failed to cancel coinbase order. " + responseJObj["results"][0].Value<string>("failure_reason"));
}
}

protected override Task<ExchangeWithdrawalResponse> OnWithdrawAsync(ExchangeWithdrawalRequest withdrawalRequest)
{
Expand Down

0 comments on commit b595119

Please sign in to comment.