Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaceSafeMarketOrderAsync - Bug #512

Closed
Ikkarus1996 opened this issue Jan 21, 2020 · 0 comments · Fixed by #514
Closed

PlaceSafeMarketOrderAsync - Bug #512

Ikkarus1996 opened this issue Jan 21, 2020 · 0 comments · Fixed by #514

Comments

@Ikkarus1996
Copy link

Ikkarus1996 commented Jan 21, 2020 •
edited
Loading

I have found two places that have caused incorrect behaviour in ExchangeAPIExtensions.PlaceSafeMarketOrderAsync():

Line 309 - The "IsBuy" parameter isn't set in the request, so it is always treated as sell-order.

Line 331 - "break" breaks the Switch-statement, not the for-loop. So the loop always runs 20 times (maxTries) and then throws an APIExeption for time out.
jjxtra added a commit that referenced this issue Jan 23, 2020
@jjxtra
Patch fix place safe market order
0e5a2bb 
Fixes #512
@jjxtra jjxtra mentioned this issue Jan 23, 2020
Merged
vslee pushed a commit that referenced this issue Jan 23, 2020
@jjxtra @vslee
Patch fix place safe market order (#514)
04eef85 
Fixes #512
szmcdull pushed a commit to szmcdull/ExchangeSharp that referenced this issue Mar 5, 2020
@jjxtra
Patch fix place safe market order (DigitalRuby#514)
679b7dd 
Fixes DigitalRuby#512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ExchangeAPIExtensions: fix PlaceSafeMarketOrderAsync() DigitalRuby/ExchangeSharp
1 participant
@Ikkarus1996