Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTX API Implementation #634

Closed
Plumbly opened this issue Aug 26, 2021 · 8 comments · Fixed by #675, #669 or #663
Closed

FTX API Implementation #634

Plumbly opened this issue Aug 26, 2021 · 8 comments · Fixed by #675, #669 or #663

Comments

@Plumbly
Copy link
Contributor

Plumbly commented Aug 26, 2021

Hi all,

Is anyone planning, or currently in the process of, integrating FTX? If not, I will look to implement it myself and make a pull request. I just wanted to make sure I don't spend time on it if someone is already on it.

@vslee
Copy link
Collaborator

vslee commented Aug 26, 2021

None that I know of, so it's all yours.

@Plumbly
Copy link
Contributor Author

Plumbly commented Aug 27, 2021

Perfect, cheers Victor.

@Plumbly
Copy link
Contributor Author

Plumbly commented Sep 22, 2021

Just a quick update that I should be ready to make a pull request for this exchange implementation by the end of the week.

@bezysoftware
Copy link
Contributor

Are you planning to add withdrawals (+withdrawal fees)? I think it shouldn't be too complicated based on their docs

@Plumbly
Copy link
Contributor Author

Plumbly commented Sep 29, 2021

I did plan to do it at some point, as I will need it for the project I work on, but didn't need it right now. However, you are right, it doesn't look like too much work, so will try find some time to add it.

@bezysoftware
Copy link
Contributor

I think there's also an issue with the namespace. It needs to be in "ExchangeSharp" namespace for the lookup by name to work: https://github.com/jjxtra/ExchangeSharp/blob/master/src/ExchangeSharp/API/Exchanges/_Base/ExchangeName.cs#L50

@vslee
Copy link
Collaborator

vslee commented Sep 30, 2021

I think there's also an issue with the namespace. It needs to be in "ExchangeSharp" namespace for the lookup by name to work: https://github.com/jjxtra/ExchangeSharp/blob/master/src/ExchangeSharp/API/Exchanges/_Base/ExchangeName.cs#L50

Yes, we'll have to fix that before the next NuGet

@Plumbly
Copy link
Contributor Author

Plumbly commented Sep 30, 2021

I have now fixed the namespace of the FTX exchange.

@vslee vslee closed this as completed in #675 Oct 7, 2021
This was linked to pull requests Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants