-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTX Exchange Implemented #662
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParseOrder method in the ExchangeKrakenAPI class will now parse the fee from the response and set it in the order result.
Added a exchange property to the ticker model to be able to identify what exchange it came from.
Added the base implementation for the FTX exchange.
Implemented onGetMarketSynbolsAsync method for FTX exchange
Implemented OnGetMarketSymbolsMetadataAsync for FTX exchange Modified ,methods to exclude to futures symbols
Added method for creating the appropriate signature on the request so that it can authenticate against the private API for the FTX exchange Implemented the OnGetAmountsAsync method for the FTX exchange.
Implemented ongetHistoricaltrades for the FTX exchange.
Modified onGetHistoricalTrade to use utility method for parsing.
Moved methods into alphabetical order
Implemented websocket connection for retrieving ticker information.
Refined websocket ticker implementation to make use of utility functions for parsing.
* checks for future coins
Implemented onPlaceOrderAsync for FTX exchange.
Added remaining overrides of methods required to be implemented to FTX exchange Added implementation of OnCancelOrderAsync Added implementation of OnGetCandleAsync
Implemented getOrderBook for FTX exchange.
Implemented GetCompletedOrders method for FTX exchange
Implemented GetTickersAsync method for FTX
Fixed minor issues in some of the methods Modified order of methods so they are alphabetical Removed debug test class.
Added FTX to supported exchanges
Modified OnGetOrderDetailsAsync for ftx exchange to include isClientOrderId parameter
Removed unused Models folder
This reverts commit 161bbba.
Apologies, just realise I included a commit that I did not want in then. I will close and reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the FTX exchange now implemented as per #634.