Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance OnGetTickersAsync throws InvalidDataException #785

Closed
BZ-CO opened this issue Sep 22, 2022 · 2 comments · Fixed by #787
Closed

Binance OnGetTickersAsync throws InvalidDataException #785

BZ-CO opened this issue Sep 22, 2022 · 2 comments · Fixed by #787

Comments

@BZ-CO
Copy link
Contributor

BZ-CO commented Sep 22, 2022

Currently we identify base/quote currencies by calling OnGetMarketSymbolsMetadataAsync().
If instrument is going to be delisted soon it may be removed from the metadata response, while it still remains in the ticker response.
This leads to throwing an exception and failing to return the remaining valid ticker data.

ParseTickerAsync() should be wrapped in try block.

Will submit PR with the fix in a minute.

@jjxtra
Copy link
Collaborator

jjxtra commented Sep 22, 2022

Thank you

@BZ-CO BZ-CO changed the title Binance OnGetTickersAsync throws InvalidDataException exception Binance OnGetTickersAsync throws InvalidDataException Sep 22, 2022
vslee pushed a commit that referenced this issue Sep 23, 2022
@vslee vslee linked a pull request Sep 23, 2022 that will close this issue
@vslee vslee closed this as completed Sep 23, 2022
@vslee
Copy link
Collaborator

vslee commented Sep 23, 2022

Thanks for your contribution! Your code changes are now available in the prerelease build: https://dev.azure.com/DigitalRuby/DigitalRuby/_artifacts/feed/DigitalRuby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants