Fixed ClientWebSocket disposal #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Oct 1, 2019
vslee
commented
- cancel CTS and set 'disposed' bool after attempting to close connection
- dispose of the webSocket
- mark messageQueue as complete
- close MemoryStream in ReadTask()
- cancel CTS and set 'disposed' bool after attempting to close connection - dispose of the webSocket - mark messageQueue as complete - close MemoryStream in ReadTask()
|
Only question I have is can we ensure Dispose is only called once? What did you run into having dispose set to true and checked before doing the task.run? |
|
If the either the cancellationToken is cancelled, or the disposed is set to true first, then the connection may be prematurely disconnected prior to the task.run running. And thus, the CloseAsync/CloseOutputAsync is not always run. |
|
In terms of Dispose() being called more than once, it would just spawn another Task, but then everything inside would be okay. It would check to see if the socket is open, and if not, then it wouldn't try to close it again. And the last three lines can be called multiple times w/o issue. |
jjxtra
approved these changes
Oct 2, 2019
vslee
added a commit
that referenced
this pull request
Oct 2, 2019
- cancel CTS and set 'disposed' bool after attempting to close connection - dispose of the webSocket - mark messageQueue as complete - close MemoryStream in ReadTask() (cherry picked from commit d577c7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.