NDAX: added REST api Support #465
Conversation
|
Since this PR uses different JSON parsing logic than the rest of the library, I'll let jjxrta review it. |
|
Can simplify the namespaces a bit though. For example, the converters and models can be in ExchangeSharp.NDAX. Also, looks like the official capitalization is NDAX. |
| using System; | ||
| using Newtonsoft.Json; | ||
|
|
||
| namespace ExchangeSharp.API.Exchanges.Ndax.Converters |
There was a problem hiding this comment.
simplify to ExchangeSharp.NDAX
| @@ -0,0 +1,16 @@ | |||
| using Newtonsoft.Json; | |||
|
|
|||
| namespace ExchangeSharp.API.Exchanges.Ndax.Models | |||
There was a problem hiding this comment.
simplify to ExchangeSharp.NDAX
|
|
||
| public partial class ExchangeName | ||
| { | ||
| public const string Ndax = "Ndax"; |
There was a problem hiding this comment.
From their site, the capitalization is NDAX. Conflicts slightly w/ C# capitalization guidelines, but I've been changing the exchange capitalization to match their official titles.
|
Let's make all those model objects use internal instead of public, I don't think anyone outside of the internals of this exchange will care to see them. Even better, make the exchange a partial class and embed the models inside of the class. |
|
Binance uses similar json parsing and model object strategy so it is fine. Depending on complexity of Exchange model objects can be helpful. |
| @@ -1,7 +1,7 @@ | |||
| using System; | |||
| using Newtonsoft.Json; | |||
|
|
|||
| namespace ExchangeSharp.API.Exchanges.Ndax.Converters | |||
| namespace ExchangeSharp.NDAX | |||
| { | |||
| public class BoolConverter : JsonConverter | |||
| { | |||
There was a problem hiding this comment.
This can be an internal class, like the others
|
Thanks guys, I'll do a followup PR with partial websocket support and any cleanup you want( just leave a comment here) tonight. :) |
No description provided.