Kraken: speedup symbol lookup in trade stream #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Oct 29, 2019
•
vslee
commented
- Kraken uses special symbols (ADA/CAD rather than ADACAD)
- a recent bugfix fa2534e now sets the WS name as an alternate name
- the ExchangeMarket is looked up for each symbol name to pull out the alternate name
- while it attempts to use caching, it is not actually able to use the cache, bc once it hits the await MakeJsonRequestAsync(), the next select statement progresses so OnGetMarketSymbolsMetadataAsync() is called for every symbol
- by priming the cache first, this allows the cache to populate first before the select statement, thus hitting OnGetMarketSymbolsMetadataAsync() once
- this is a hacky way to fix this problem, unless @jjxtra can think of a more elegant way?
- Kraken uses special symbols (ADA/CAD rather than ADACAD) - a recent bugfix fa2534e now sets the WS name as an alternate name - this ExchangeMarket is looked up for each symbol name to pull out the alternate name - while it attempts to use caching, it is not actually able to use the cache, bc once it hits the await MakeJsonRequestAsync() in OnGetMarketSymbolsMetadataAsync(), the next select statement progresses so OnGetMarketSymbolsMetadataAsync() is called for every symbol - by priming the cache first, this allows the cache to populate first before the select statement, thus hitting OnGetMarketSymbolsMetadataAsync() once
|
Could we just call OnGetMarketSymbolsMetadataAsync to prime the cache instead? |
|
I tried that, but that doesn't seem to prime it... |
|
Maybe just |
|
that works |
jjxtra
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.