-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BL3P: added buy/sell/cancel #475
Conversation
|
||
private string GetSignKey(IHttpWebRequest request, string formData) | ||
{ | ||
//TODO: Use csharp8 ranges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use System.Range
we would have to drop net472
as a a target framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not an option unfortunately right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that mean that we would have to drop support for netstandard 2.0 as well in order to use System.Range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true. One thing that I said that was wrong is that we need to drop net472
when actually what I should have said is that there's no need to support net472
when we already support netstandard20
. With that clarified, I noticed that those types (Range
and Index
) are not available in all runtimes (only netstandard2.1
and netcoreapp30
) and in that case we could use a package that ports those specific APIs to netstandard20
like this one https://github.com/bgrainger/IndexRange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could create an issue out of this conversation 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use a package that ports those specific APIs to
netstandard20
like this one https://github.com/bgrainger/IndexRange
Yes that's a good way to keep netstandard20 and start using the new APIs
Maybe we could create an issue out of this conversation 🤔
Yes feel free
namespace ExchangeSharp.API.Exchanges.BL3P.Enums | ||
{ | ||
public enum BL3PCurrencyFee : byte | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be made internal
, because, it's one of the settings of ExchangeBL3PAPI
. See prop ExchangeBL3PAPI.DefaultFeeCurrency
.
Looks like merge conflict, other than that I'm good to merge in |
Also, adds some new shiny console options for those three options.
Help for the "buy" command