Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to netstandard2.0 #487

Merged
merged 9 commits into from
Nov 13, 2019
Merged

Move to netstandard2.0 #487

merged 9 commits into from
Nov 13, 2019

Conversation

johnnyasantoss
Copy link
Collaborator

@johnnyasantoss johnnyasantoss commented Nov 12, 2019

  • Fixes Target netcoreapp2.0 #477
  • Makes the default target netstandard2.0
  • Move files into a more simplified structure
    • image
  • Moves the winforms dependency to a separate package (even though I could not find where it is being used)
  • Remove old files like App.config and packages.config (the first was a copy lying around in the root of the project and the second is not longer used)
  • Does not change any csharp code (Changes were made to Logger and ExchangePoloniexAPI to use a new form of accessing embedded resources)

@johnnyasantoss johnnyasantoss marked this pull request as ready for review November 12, 2019 14:30
@johnnyasantoss johnnyasantoss changed the title [WIP] Move to netstandard2.0 Move to netstandard2.0 Nov 12, 2019
@johnnyasantoss
Copy link
Collaborator Author

Everything still working just fine :)

image

@johnnyasantoss
Copy link
Collaborator Author

Now, the only thing left to do is to fix this (given that HAS_WINDOWS_FORMS will never be defined):

https://github.com/jjxtra/ExchangeSharp/blob/ee8e4d13a78025fbb73cddda4e133fde858e637b/src/ExchangeSharp/API/Common/BaseAPI.cs#L257-L283

@jjxtra
Copy link
Collaborator

jjxtra commented Nov 12, 2019

Probably we can boot that piece of code and move it into the win forms project with a note.

@jjxtra
Copy link
Collaborator

jjxtra commented Nov 12, 2019

Thanks for all your work on this, I appreciate your attention to detail and I think the new organization structure will be very good.

jjxtra
jjxtra previously approved these changes Nov 13, 2019
Copy link
Collaborator

@jjxtra jjxtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice re-org, project is getting big enough to warrant splitting out into another level of hierarchy.

@jjxtra
Copy link
Collaborator

jjxtra commented Nov 13, 2019

@johnnyasantoss I made you a contributor by the way, appreciate you dedicating so much time to this project.

@johnnyasantoss
Copy link
Collaborator Author

@johnnyasantoss I made you a contributor by the way, appreciate you dedicating so much time to this project.

Thank you! :)
I'll try to keep helping as much as I can

@johnnyasantoss
Copy link
Collaborator Author

Rebased!
Please take another look :) @jjxtra @vslee

@jjxtra
Copy link
Collaborator

jjxtra commented Nov 13, 2019

Thanks for the rebase! Typically I always do squash and merge, but if it helps you to manager your commits before merge that's awesome :)

jjxtra
jjxtra previously approved these changes Nov 13, 2019
@johnnyasantoss
Copy link
Collaborator Author

I also prefer squashing the PRs. It makes the git commit history more consistent.

@vslee
Copy link
Collaborator

vslee commented Nov 13, 2019

The changes in this PR cover so much code that by merging the two other PRs, it created additional conflicts. Can you rebase again?

@johnnyasantoss
Copy link
Collaborator Author

Yep, it moves basically every file in the solution, so it can be a bit cumbersome to have it updated.

@johnnyasantoss
Copy link
Collaborator Author

@vslee done 😃

Copy link
Collaborator

@vslee vslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reorganization

@vslee vslee merged commit a5e8533 into DigitalRuby:master Nov 13, 2019
@johnnyasantoss johnnyasantoss deleted the netstandard branch November 13, 2019 18:29
@johnnyasantoss
Copy link
Collaborator Author

@vslee There are some weird files in the root folder. I just saw.
I'll send a new PR to fix it immediately. We need a CI asap to stop things like this from happening 🙈

@vslee
Copy link
Collaborator

vslee commented Nov 13, 2019

No worries, part of the dev process

szmcdull pushed a commit to szmcdull/ExchangeSharp that referenced this pull request Mar 5, 2020
* Change to netstandard20

* Add Roslyn analyzers

* Move files to new structure

* Add global.json with target to .netcore 3.0

* Move win forms dependencies to another package

* Target net472

* Use new resource manager

* Migrate example forms project to new csproj style with hvanbakel/CsprojToVs2017

* Fix azure pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target netcoreapp2.0
3 participants