-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to netstandard2.0 #487
Conversation
Now, the only thing left to do is to fix this (given that |
Probably we can boot that piece of code and move it into the win forms project with a note. |
Thanks for all your work on this, I appreciate your attention to detail and I think the new organization structure will be very good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice re-org, project is getting big enough to warrant splitting out into another level of hierarchy.
@johnnyasantoss I made you a contributor by the way, appreciate you dedicating so much time to this project. |
Thank you! :) |
Thanks for the rebase! Typically I always do squash and merge, but if it helps you to manager your commits before merge that's awesome :) |
I also prefer squashing the PRs. It makes the git commit history more consistent. |
The changes in this PR cover so much code that by merging the two other PRs, it created additional conflicts. Can you rebase again? |
Yep, it moves basically every file in the solution, so it can be a bit cumbersome to have it updated. |
@vslee done 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reorganization
@vslee There are some weird files in the root folder. I just saw. |
No worries, part of the dev process |
* Change to netstandard20 * Add Roslyn analyzers * Move files to new structure * Add global.json with target to .netcore 3.0 * Move win forms dependencies to another package * Target net472 * Use new resource manager * Migrate example forms project to new csproj style with hvanbakel/CsprojToVs2017 * Fix azure pipelines
netstandard2.0
App.config
andpackages.config
(the first was a copy lying around in the root of the project and the second is not longer used)Does not change any(Changes were made tocsharp
codeLogger
andExchangePoloniexAPI
to use a new form of accessing embedded resources)