Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: ignore tests that were failing on OSX #493

Merged
merged 1 commit into from
Nov 19, 2019
Merged

CI/CD: ignore tests that were failing on OSX #493

merged 1 commit into from
Nov 19, 2019

Conversation

johnnyasantoss
Copy link
Collaborator

Used this approach to implement a conditional test method attribute.

@johnnyasantoss johnnyasantoss added the maintenance such as tests label Nov 19, 2019
Copy link
Collaborator

@vslee vslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking the issue here to make it easier to find: https://github.com/dotnet/corefx/issues/42607

This attribute addition will make it easier to ignore tests on a platform specific basis in the future.

@vslee vslee merged commit 16c0cc3 into DigitalRuby:master Nov 19, 2019
@johnnyasantoss johnnyasantoss deleted the test-osx branch November 21, 2019 12:33
@vslee vslee changed the title Ignore test that were failing on OSX CI/CD: ignore tests that were failing on OSX Nov 21, 2019
@vslee vslee added the CI/CD label Nov 21, 2019
szmcdull pushed a commit to szmcdull/ExchangeSharp that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants