NDAX: fix symbol separator bug #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Nov 27, 2019
vslee
commented
- NDAX sometimes uses _ as a symbol separater and sometimes it does not
- change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _
- then search both ways if needed
- NDAX sometimes uses _ as a symbol separater and sometimes it does not - change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _ - then search both ways if needed
|
Wow whoever made their api was drunk or something. Thanks for doing this... |
jjxtra
approved these changes
Nov 27, 2019
szmcdull
pushed a commit
to szmcdull/ExchangeSharp
that referenced
this pull request
Mar 5, 2020
- NDAX sometimes uses _ as a symbol separater and sometimes it does not - change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _ - then search both ways if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.