added ExchangeAPI.GetExchangeAPIFromClassName() #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjxtra
approved these changes
Feb 5, 2020
vslee
changed the title
szmcdull
pushed a commit
to szmcdull/ExchangeSharp
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a GetExchangeAPI() method that gets an ExchangeAPI instance by its corresponding .Name property, which is nice. However sometimes we want to fetch the instance by the class name.
So I introduce GetExchangeAPIFromClassName() which has the same functionality but you can fetch by class name now.
Why should this be in the base code? 1) this is the simplest place to put it 2) overhead is mimimal 3) the Name <-> class name relationship is somewhat akward due to architecture. This is a step at bridging the gap.
Thanks yall!