Feature: Add support for ws-orderbook to Kraken and Gemini Exchanges
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jjxtra
There is some code formatting changes in this diff to move these files to tabs for indention. That's mainly in the first commit.
Biggest change here is adding
isWebSocketoverload parameter to theGetMarketSymbolsAsync(bool isWebSocket = false);andOnGetMarketSymbolsAsync(bool isWebSocket = false)methods. This was needed because Kraken's WebSocket symbols are different from the REST API symbols 🙄.ETHDAIvs.ETH/DAIYou had added some support for Gemini
ws-orderbook, but it wasn't updating. Similar to thews-tickerissue we exchanged emails about. That's fix now.