Fixes for Bittrex and Kraken after testing live orders. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gemini lower case symbol names. Pass isWebsocket flag in console app.
…x API returns HttpStatusCode.Created when placing an order.
…When submitting a limit order, add required timeInForce property.
EcBen
commented
Jun 11, 2021
| @@ -252,7 +252,25 @@ protected override async Task<ExchangeTicker> OnGetTickerAsync(string marketSymb | |||
| #region OrderBooks | |||
| protected override async Task<ExchangeOrderBook> OnGetOrderBookAsync(string marketSymbol, int maxCount = 25) | |||
| { | |||
| JToken token = await MakeJsonRequestAsync<JToken>("/markets/" + marketSymbol + "/orderbook" + marketSymbol + "&depth=" + maxCount); | |||
There was a problem hiding this comment.
This URL is invalid. Fixed below.
| @@ -252,7 +252,25 @@ protected override async Task<ExchangeTicker> OnGetTickerAsync(string marketSymb | |||
| #region OrderBooks | |||
| protected override async Task<ExchangeOrderBook> OnGetOrderBookAsync(string marketSymbol, int maxCount = 25) | |||
| { | |||
| JToken token = await MakeJsonRequestAsync<JToken>("/markets/" + marketSymbol + "/orderbook" + marketSymbol + "&depth=" + maxCount); | |||
| // Bittrex API allowed values are [1, 25, 500], default is 25. | |||
There was a problem hiding this comment.
| @@ -370,7 +388,7 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd | |||
| if (order.OrderType == ExchangeSharp.OrderType.Limit) | |||
| { | |||
| orderParams.Add("limit", orderPrice); | |||
| //orderParams.Add("timeInForce", "GOOD_TIL_CANCELLED"); | |||
| orderParams.Add("timeInForce", "GOOD_TIL_CANCELLED"); | |||
There was a problem hiding this comment.
Bittrex V3 API is saying this is a required parameter now for limit orders.
| object nonce = await GenerateNonceAsync(); | ||
| Dictionary<string, object> payload = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase) | ||
| { { "pair", order.MarketSymbol }, { "type", (order.IsBuy ? "buy" : "sell") }, { "ordertype", order.OrderType.ToString().ToLowerInvariant() }, { "volume", order.RoundAmount().ToStringInvariant() }, { "trading_agreement", "agree" }, { "nonce", nonce } | ||
| }; | ||
| if (order.OrderType != OrderType.Market) | ||
| { | ||
| payload.Add("price", order.Price.ToStringInvariant()); | ||
| int precision = BitConverter.GetBytes(Decimal.GetBits((decimal)market.PriceStepSize)[3])[2]; | ||
| payload.Add("price", Math.Round(order.Price, precision).ToStringInvariant()); |
There was a problem hiding this comment.
This rounding avoids an error returned by Kraken's API that price can only have so many decimals.
vslee
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.