Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TryAddWithoutValidation() when setting HTTP headers. #611

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Use TryAddWithoutValidation() when setting HTTP headers. #611

merged 2 commits into from
Jul 13, 2021

Conversation

EcBen
Copy link
Contributor

@EcBen EcBen commented Jul 13, 2021

  • Use TryAddWithoutValidation() when setting HTTP headers.
  • Switch APIRequestMaker.cs to tab indention.
  • Allow override of ConnectWebSocketAsync() and friends to prep for Bittrex v3 WebSocket support.

contentType = value;
break;
default:
Request.Headers.TryAddWithoutValidation(header, value);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only actual change is here for #610. The rest is linting.

@vslee vslee added the bug label Jul 13, 2021
@vslee vslee merged commit 947446d into DigitalRuby:master Jul 13, 2021
@vslee vslee changed the title Fixes #610 - Use TryAddWithoutValidation() when setting HTTP headers. Use TryAddWithoutValidation() when setting HTTP headers. Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlaceOrderAsync throwing exception on Poloniex after changing to System.Net.Http.HttpClient.
2 participants