Fix Kraken WS orderbook updates and add checksum support #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Kraken implementation for order-book updates is incorrect. It assumes each update will include either one "a" or one "b" block and that the message contains exactly 5 elements.
In most cases this is the case however the API can and sometimes does send both an "a" and "b" block in the same message. I have verified this myself with a live feed (examples are is also shown in the API docs) and in this case the behavior is faulty. The market symbol is read wrongly and the whole message will therefore get missed leading to order-book mismatch locally.
My change follows the spec more accurately and also adds support for Kraken's checksum property (https://docs.kraken.com/websockets/#book-checksum). I do not know if other exchanges provide this but it is vital to ensure your local order book is correct in case of missed messages. I have implemented the simplest possible API change for
ExchangeOrderBook.Checksum
which could be used by other exchange implementations if desired.