Rewrite Binance OnGetUserDataWebSocketAsync() to be multi-exchange friendly #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exchange friendly - this PR contains 3 breaking changes: - ExchangeOrderResult.FillDate has been changed to CompletionDate and made it nullable. This is because this can represent either the Filled date or the Cancelled, Rejected, or Expired date. And it doesn't necessarily have a value. -ExchangeOrderResult.AmountFilled changed to nullable. Not all exchanges provide this value on every call. -removed listenKey from GetUserDataWebSocketAsync() Other changes - inlined call to BinanceGroupCommon.GetListenKeyAsync() - made parse() methods in BinanceGroupCommon static - added ExchangeAPIOrderResultExtensions with Completed enums - added ExchangeBalances - fixed BinanceGroupCommon.OnGetMarketSymbolsAsync() (updated URL)
- not all exchanges provide this on every response
jjxtra
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR contains 3 breaking changes:
ExchangeOrderResult.FillDatehas been changed toCompletionDateand made nullable. This is because this can represent either the Filled date or the Cancelled, Rejected, or Expired date. And it doesn't necessarily have a value.ExchangeOrderResult.AmountFilledandExchangeOrderResult.Feeschanged to nullable. Not all exchanges provide these values on every call.listenKeyfromGetUserDataWebSocketAsync()Other changes
BinanceGroupCommon.GetListenKeyAsync()BinanceGroupCommonstaticExchangeAPIOrderResultExtensionswith Completed enumsExchangeBalancesBinanceGroupCommon.OnGetMarketSymbolsAsync()(updated URL)