Added Expired and PendingOpen to ExchangeAPIOrderResult #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following breaking changes to the ExchangeAPIOrderResult enum: - PendingOpen is an important state that many exchanges have, which is separate from Open - Renamed Pending state to Open - Renamed Error state to Rejected, since this is how most exchanges refer to it - Added Expired state, which is separate from Rejected also contains the following changes - added stricter checks to FTX OnGetOrderDetailsAsync() and OnPlaceOrderAsync isPostOnly - improved FTX ToExchangeAPIOrderResult(), renamed to FTXExtensions to reduce collisions in the future
jjxtra
approved these changes
Sep 30, 2021
|
Great stuff ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following breaking changes to the
ExchangeAPIOrderResultenum:PendingOpenis an important state that many exchanges have, which is separate fromOpenPendingstate toOpenErrorstate toRejected, since this is how most exchanges refer to itExpiredstate, which is separate fromRejectedalso contains the following changes
OnGetOrderDetailsAsync()andOnPlaceOrderAsyncisPostOnlyToExchangeAPIOrderResult(), renamed toFTXExtensionsto reduce possibility of collision in the future