Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize exception types #735

Merged
merged 1 commit into from
Feb 12, 2022
Merged

standardize exception types #735

merged 1 commit into from
Feb 12, 2022

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Feb 12, 2022

  • use NotImplementedException, InvalidOperationException, NotSupportedException, ArgumentException, ArgumentNullException when appropriate
  • opens up room in the future to create more specific exceptions derived from above exceptions

@vslee
standardize exception types
0044c1b 
- use NotImplementedException, InvalidOperationException, NotSupportedException, ArgumentException, ArgumentNullException when appropriate
- opens up room in the future to create more specific exceptions derived from above exceptions
@vslee vslee requested a review from jjxtra February 12, 2022 22:50
@vslee vslee merged commit cbdd172 into DigitalRuby:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjxtra jjxtra jjxtra approved these changes

Assignees
No one assigned
Labels
breaking change maintenance such as tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vslee @jjxtra