fix: Binance issue where Fees = null so null += Anything == null #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O-Mutt
changed the title
|
I would hope we could get this released as a bug version as this is blocking my current production environment from being able to manage trades appropriately. |
vslee
approved these changes
Aug 30, 2023
|
Thanks for submitting all of these PRs. I can prepare a new release in a few days. If you'd like to get any other PRs in before then, that'd be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the binance API returns the correct fees but the way we are handling fees is with a nullable decimal causing the += of fees to be null