fix: buy order results bug in OKEx #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
O-Mutt
commented
Feb 7, 2024
•
O-Mutt
commented
O-Mutt
commented
Feb 7, 2024
Comment on lines
+854
to
+865
| var avgPrice = decimal.TryParse(token["avgPx"].Value<string>(), out var tempAvgPx) ? tempAvgPx : default; | ||
| var price = decimal.TryParse(token["px"].Value<string>(), out var tempPx) ? tempPx : default; | ||
| if (avgPrice == default && price != default) | ||
| { | ||
| avgPrice = price; | ||
| } | ||
| else if (price == default && avgPrice != default) | ||
| { | ||
| price = avgPrice; | ||
| } | ||
| newResult.Price = price; | ||
| newResult.AveragePrice = avgPrice; |
There was a problem hiding this comment.
Seems there was an expectation that the inverse was true previously. I made it a bit safer parsing and use the other value if there is missing data one way or the other.
i.e. if we don't have avgPx use px, if we don't have px use avgPx, if we have both, Great!
jjxtra
approved these changes
Feb 7, 2024
vslee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.