Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue frontend #173

Merged
merged 35 commits into from
Mar 12, 2024
Merged

Vue frontend #173

merged 35 commits into from
Mar 12, 2024

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Dec 1, 2023 •
edited
Loading

This achieves feature parity with the current UI using vue instead of jinja templates.

@marySalvi marySalvi marked this pull request as ready for review December 5, 2023 15:03
@marySalvi marySalvi changed the title Vue frontend [WIP] Vue frontend Dec 5, 2023
@marySalvi marySalvi force-pushed the vue-frontend branch 2 times, most recently from 406251a to 04be8a1 Compare January 10, 2024 18:40
@marySalvi marySalvi force-pushed the vue-frontend branch 2 times, most recently from 151f3a9 to 6dcdce8 Compare February 27, 2024 19:04
@marySalvi
Create initial Vue app
c8c3abb
@marySalvi
Change directory endpoint to return json instead of html
7cc6d53
@marySalvi
Allow 8080 origin
585eee8
@marySalvi
Remove vite example code and assets
df67977
@marySalvi
Configure app to use tailwind and Daisyui
246d21d
@marySalvi
Update directory endpoint and create fetch function
eea56e0
@marySalvi
Update frontend README and reset env variable on sigint
38c0e81
@marySalvi
Mount UI dist to fastapi endpoint
d178c47
@marySalvi
Add vue assets to binary build
6da10fb
@marySalvi
Update hatchling dependcies and web asset directory
52e60dc
@marySalvi
Add development workflow
d55acbb
@marySalvi
Fix readme typo
ab82ef6
@marySalvi
Start frame-work for redact components
342fd55
@marySalvi
Add menu steps and file browser modal
4f6aea0
@marySalvi
Update DirectoryData class to provide name and path to ui
f9efda5
@marySalvi
Add icons
2e56fef
@marySalvi
Change from document selector to ref usage. Add selected directory te…
1ed7057 
…xt and store
@marySalvi
Change api to return both path and name for path instances
ce0c74b
@marySalvi
Standardize vue component order
7d33f21
@marySalvi
Add redaction functionalityx
2613ee5
@marySalvi
Add progress bar
f9bcf25
@marySalvi
Remove jinja templates and djlint. Linting updates
2fd401a
@marySalvi
Add linting and formatting to frontend
65c117a
@marySalvi marySalvi changed the title [WIP] Vue frontend Vue frontend Mar 12, 2024
@marySalvi marySalvi requested a review from manthey March 12, 2024 14:35
manthey
manthey approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@manthey manthey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me. I checked the component PRs as they came along; I'd say merge this and we'll sort any issues I missed as we do UI work.

@marySalvi marySalvi merged commit add5404 into main Mar 12, 2024
4 checks passed
@marySalvi marySalvi deleted the vue-frontend branch March 12, 2024 18:25
naglepuff added a commit that referenced this pull request Mar 19, 2024
@naglepuff
Move code out of deleted file
16a9495 
#173 deleted the top level `gui.py`, which meant that code added in prior
commits to this feature branch (`193-dicom-associated-images`) needed
to be moved after a merge with main. I followed the separation present in
the new code structure, with all dependencies on image-related libraries
present in `imagedephi/gui/utils/image.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthey manthey manthey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marySalvi @manthey