Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #274

Merged
merged 5 commits into from
Nov 26, 2024
Merged

UI improvements #274

merged 5 commits into from
Nov 26, 2024

Conversation

marySalvi
Copy link
Collaborator

  • Adds a loading feedback on the filebrowser
  • Makes the Image Data Table 'denser', expand across more of the page and increases image preview size (slightly)
  • Image lists for the filebrowser are created dynamically based on the space available.

@marySalvi marySalvi requested a review from manthey November 19, 2024 21:12
@marySalvi
Copy link
Collaborator Author

@manthey I believe this should also resolve #250. Would you mind checking when you review? Thanks!

@manthey
Copy link
Contributor

manthey commented Nov 22, 2024

The "Collecting Directory Data" message doesn't go away; I was selecting an empty directory for output.

It also didn't go away in a directory that had no sub-directories but had images.

@manthey
Copy link
Contributor

manthey commented Nov 22, 2024

I'm getting outer scroll bars on the page:
image

@marySalvi
Copy link
Collaborator Author

I'm getting outer scroll bars on the page:

hopefully fixed in d6b0b72. Apologies for the back and forth on this, I am having trouble recreating the issue.

@marySalvi
Copy link
Collaborator Author

The "Collecting Directory Data" message doesn't go away; I was selecting an empty directory for output.

It also didn't go away in a directory that had no sub-directories but had images.

fixed in b283bb6

@marySalvi marySalvi merged commit e32d449 into main Nov 26, 2024
4 checks passed
@marySalvi marySalvi deleted the ui-improvements branch November 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants